Skip to content

Added product navigation in wish list page #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Added product navigation in wish list page #4472

merged 1 commit into from
Jul 1, 2025

Conversation

del22123
Copy link
Collaborator

Description

Added product navigation in wish list page

Related Issue

https://jira.corp.adobe.com/browse/PWA-3458

Closes #PWA-3458

Acceptance

Verification Stakeholders

Specification

Verification Steps

Add a product to wish list
Go to wish list page and click on the product image or product name

Actual result : Neither product name nor product image navigates to product page

Fixed result : Product name nor product image navigates to product page when clicked

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del22123 del22123 requested a review from glo82145 June 25, 2025 10:38
@del22123 del22123 self-assigned this Jun 25, 2025
@del22123 del22123 added pkg:peregrine version: Patch This changeset includes backwards compatible bug fixes. Progress: ready for review labels Jun 25, 2025
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 25, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • contains valid CMS Page data:
    • CypressError: `cy.visit()` failed trying to load:

      https://pr-4472.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    displays subcategories from the default root category:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4472.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    displays assigned products:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4472.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,contains valid CMS Page data specific to the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4472.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    shows categories specific to the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4472.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    shows products specific to the categories in the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4472.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,lets users add products to cart regardless of store view:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4472.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against d639a6d

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against d639a6d

@pwa-studio-bot
Copy link
Collaborator

Messages
📖

Associated JIRA tickets: PWA-3458.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against d639a6d

@del22123 del22123 closed this Jun 26, 2025
@del22123 del22123 reopened this Jun 26, 2025
@glo82145 glo82145 merged commit 5bf2fd5 into develop Jul 1, 2025
6 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: ready for review version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants