Skip to content

build(client): Add new end-to-end test package for tinylicious-client #24868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tylerbutler
Copy link
Member

This is split out of #24849. This change adds the new package and subsequent changes will add tests to it. The package is private and not published to any feeds.

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 23:01
@github-actions github-actions bot added dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Jun 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new private end-to-end test package for the Tinylicious client, providing the initial scaffolding and configuration needed to add tests in a subsequent change.

  • Adds TypeScript test configuration and build scripts
  • Provides a Tinylicious client factory helper and Mocha setup
  • Includes package metadata, lint/format config, README, LICENSE, changelog, and ignore files

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/test/tsconfig.json Test TypeScript configuration with temporary overrides
src/test/TinyliciousClientFactory.ts Factory function to create a Tinylicious client
src/test/.mocharc.cjs Mocha configuration for running tests
package.json Defines package metadata, scripts, and dependencies
biome.jsonc Extends shared Biome formatting/linting config
README.md Documentation scaffold (auto-generated content)
LICENSE MIT license file
CHANGELOG.md Placeholder changelog for the new package
.npmignore Exclusions for npm package publish
.gitignore Common files and directories to ignore in Git
.eslintrc.cjs ESLint configuration with test overrides
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/service-clients/end-to-end-tests/tinylicious-client/src/test/TinyliciousClientFactory.ts:15

  • [nitpick] Replace the placeholder TODO comment with a meaningful description of what this factory function does.
 * TODO

packages/service-clients/end-to-end-tests/tinylicious-client/README.md:1

  • The README title does not match the package name in package.json (which is '@fluid-private/tinylicious-end-to-end-tests'). Please update the README header to reflect the correct package name.
# @fluidframework/tinylicious-end-to-end-tests

Comment on lines 7 to 8
// FIXME: Revert before merge
"noUnusedLocals": false,
Copy link
Preview

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the temporary FIXME comment and ensure the tsconfig settings are finalized before merging.

Suggested change
// FIXME: Revert before merge
"noUnusedLocals": false,
"noUnusedLocals": true,

Copilot uses AI. Check for mistakes.

Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  225443 links
    1710 destination URLs
    1941 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant