-
Notifications
You must be signed in to change notification settings - Fork 550
[v2.50] Remove IFluidHandleInternal.bind #24870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
markfields
wants to merge
10
commits into
main
Choose a base branch
from
test/remove-handle-bind-fn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be removed from FluidObjectHandle when bind is removed from the interface
All legacy-alpha and backCompat breaking only (not forwardCompat)
eba7b09
to
bc259b2
Compare
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Guidance
Note that this branch contains the pre-requisite changes in #24863. This allows me to run the partner integration pipeline with the whole change before merging that one, to confirm there are no other pre-requisite changes needed. Once that PR is merged, I'll merge main here and that diff will vanish.
Fixes #24557
Description
IFluidHandleInternal.bind
was deprecated in 2.40 (via #24553), see release notes entry for more details.Breaking Changes
This is a legacy-alpha breaking change and must not be merged until
main
is open for breaking changes for 2.50. There are no known usages in partners using the legacy-alpha API set.