Skip to content

[v2.50] Remove IFluidHandleInternal.bind #24870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

markfields
Copy link
Member

Reviewer Guidance

Note that this branch contains the pre-requisite changes in #24863. This allows me to run the partner integration pipeline with the whole change before merging that one, to confirm there are no other pre-requisite changes needed. Once that PR is merged, I'll merge main here and that diff will vanish.
 
Fixes #24557

Description

IFluidHandleInternal.bind was deprecated in 2.40 (via #24553), see release notes entry for more details.

Breaking Changes

This is a legacy-alpha breaking change and must not be merged until main is open for breaking changes for 2.50. There are no known usages in partners using the legacy-alpha API set.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels Jun 18, 2025
All legacy-alpha and backCompat breaking only (not forwardCompat)
@github-actions github-actions bot added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Jun 18, 2025
@markfields markfields force-pushed the test/remove-handle-bind-fn branch from eba7b09 to bc259b2 Compare June 19, 2025 00:08
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  225443 links
    1710 destination URLs
    1941 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IFluidHandleInternal.bind function
1 participant