refactor(client-presence): Remove all usage of audience #24879
+58
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the client presence logic by removing all dependencies on the “audience” API and introducing a remoteDisconnected signal alongside datastore flags to track client disconnections.
- Emit a new
remoteDisconnectedevent from the runtime on incoming ClientLeave signals. - Remove
getAudiencecalls and replaceaudience.removeMemberwithremoteDisconnect. - Expand the datastore schema to mark connections as disconnected instead of querying audience membership.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/runtime/container-runtime/src/containerRuntime.ts | Added inbound signal handler to emit remoteDisconnected. |
| packages/runtime/container-runtime-definitions/src/containerExtension.ts | Removed getAudience, added remoteDisconnected to the event interface. |
| packages/loader/container-loader/src/deltaManager.ts | (Unintentional) stray empty string literal inserted. |
| packages/framework/presence/src/test/presenceManager.spec.ts | Updated tests to call remoteDisconnect instead of removeMember. |
| packages/framework/presence/src/test/mockEphemeralRuntime.ts | Removed MockAudience support and added remoteDisconnect logic. |
| packages/framework/presence/src/systemWorkspace.ts | Removed audience import, added disconnected flag to state and logic. |
| packages/framework/presence/src/presenceManager.ts | Switched from audience removeMember listener to remoteDisconnected. |
| packages/framework/presence/src/datastorePresenceManagerFactory.ts | Removed getAudience binding. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
WillieHabi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently use audience.removeMember in presence to track when remote clients disconnect. To move off this dependency, we use a combination of ClientLeave signals sent from service and Quroum removeMember events to track the disconnections of read and write clients respectively.
We also remove the checks we make against audience to verify connection status of remote clients in system workspace. We instead mark remote disconnections within the datastore to know which connectionIds are inactive.