feat(build-cli): New vnext generate:changelog command #24899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
tylerbutler
commented
Jun 23, 2025
build-tools/packages/build-cli/src/commands/vnext/generate/changelog.ts
Outdated
Show resolved
Hide resolved
tylerbutler
commented
Jun 23, 2025
build-tools/packages/build-cli/src/commands/vnext/generate/changelog.ts
Outdated
Show resolved
Hide resolved
alexvy86
approved these changes
Jun 24, 2025
| @@ -55,8 +55,8 @@ export const releaseGroupFlag = Flags.custom<ReleaseGroup>({ | |||
| * A re-usable CLI flag to parse release group names. | |||
| */ | |||
| export const releaseGroupNameFlag = Flags.custom<ReleaseGroupName>({ | |||
| required: true, | |||
There was a problem hiding this comment.
This is default so redundant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a replacement vnext command for
generate:changelog. The new command is based on the BuildProject infrastructure as all vnext commands are.The primary change in this command is that git is no longer used to revert changes. All changes are just made locally and must be committed manually. The main thing we were reverting was a version bump, which is trivial to reset using the
setVersionfunction in build-infra.I also moved the
canonicalizeChangesetfunction to a shared location and call it from both the old and new commands.Once we feel good about the new command, we can remove the old one, replace it with the one in vnext, and add a deprecated alias for the now-removed vnext command.
A lot of the approach here is informed by changesets/changesets#595, which is basically what we'd like. Ideally we could ask changesets to generate changelogs for a version that we provide (without also bumping versions), but that doesn't exist at the moment.