-
Notifications
You must be signed in to change notification settings - Fork 552
test(shared-tree): Add memory usage performance benchmarks for SharedTree table APIs #24900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces performance benchmark tests for SharedTree’s table APIs and aligns performance documentation between SharedTree and SharedMatrix. Key changes include:
- New performance test utilities for table operations (insertions, removals, undo/redo) in SharedTree.
- Added documentation notes in the SharedMatrix benchmarks to ensure consistency with SharedTree.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/dds/tree/src/test/tablePerformanceTestUtilities.ts | Adds table schema definitions and utility functions for performance benchmarking. |
packages/dds/matrix/src/test/memory/sharedMatrix.spec.ts | Updates benchmark documentation to reference SharedTree benchmarks for consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for matrix changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one more style comment. Otherwise, looking good! Happy we were able to make these tests look more similar to the runtime ones 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, but could you include the memory usage metrics in the PR description? It currently shows the list of tests passing, but not the reported metrics.
We should also probably hold off on merging this until we've sorted out the CI time issues we discovered with the other PR.
Description
This PR introduces performance benchmark tests for SharedTree's table-related APIs, focusing on standard operations. The benchmarks cover:
Insertion of rows, columns, and cells
Includes insertion at the middle of the table for rows and columns. Similarly, tests removal for rows and columns.
Test Result