-
Notifications
You must be signed in to change notification settings - Fork 550
refactor(tree): Leverage schema type-narrowing helper functions #24909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Josmithr
merged 10 commits into
microsoft:main
from
Josmithr:tree/use-schema-type-narrowing-helpers
Jun 25, 2025
Merged
refactor(tree): Leverage schema type-narrowing helper functions #24909
Josmithr
merged 10 commits into
microsoft:main
from
Josmithr:tree/use-schema-type-narrowing-helpers
Jun 25, 2025
+60
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors schema-kind checks by leveraging existing type-narrowing helper functions instead of direct node.kind
comparisons.
- Replaced all explicit
schema.kind === NodeKind.*
checks withis*NodeSchema(schema)
and added correspondingassert
calls. - Updated function signatures (
arrayToFlexContent
,mapToFlexContent
,objectToFlexContent
) to accept specific schema types. - Consolidated imports of schema type guards and disabled internal-module linting around them.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
packages/dds/tree/src/simple-tree/unhydratedFlexTreeFromInsertable.ts | Swapped kind checks for is*NodeSchema asserts; tightened helper signatures and reorganized imports |
packages/dds/tree/src/simple-tree/api/treeNodeApi.ts | Changed array-kind branch to use isArrayNodeSchema instead of NodeKind.Array |
packages/dds/tree/src/simple-tree/api/customTree.ts | Replaced NodeKind.Array check with isArrayNodeSchema |
packages/dds/tree/src/simple-tree/api/configuration.ts | Updated union validation to use isArrayNodeSchema /isMapNodeSchema and refined typed arrays/maps |
Josmithr
commented
Jun 24, 2025
packages/dds/tree/src/simple-tree/unhydratedFlexTreeFromInsertable.ts
Outdated
Show resolved
Hide resolved
packages/dds/tree/src/simple-tree/unhydratedFlexTreeFromInsertable.ts
Outdated
Show resolved
Hide resolved
packages/dds/tree/src/simple-tree/unhydratedFlexTreeFromInsertable.ts
Outdated
Show resolved
Hide resolved
CraigMacomber
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces some explicit
node.kind
equality checks with existing type-narrowing helpers.