feat: ensure env.sh does not fail with unboud var #5203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If -u is set where this env script is sourced from, it can error out with `./env.sh: line 34: !checkVar: unbound variable`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If -u is set where this env script is sourced from, it can error out with
./env.sh: line 34: !checkVar: unbound variableContext
Ado setup breaks when called from a parent with -u set
Description
Set +u so the env.sh script does not error with it`s own onboad var
Risk Assessment (Low / Medium / High)
Low. Unboand var check was not set in the script in the first place and impact is very limited
Unit Tests Added or Updated (Yes / No)
NO
Additional Testing Performed
verified with manual flag setting and running agent