-
Notifications
You must be signed in to change notification settings - Fork 888
Fix for bug MSRC97007 #5206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rajmishra1997
wants to merge
5
commits into
master
Choose a base branch
from
users/rajmishra/FixMSRC97007
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix for bug MSRC97007 #5206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Supported commands
See additional documentation. |
Azure Pipelines successfully started running 1 pipeline(s). |
tarunramsinghani
requested changes
May 13, 2025
tarunramsinghani
requested changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure there are no unneccesary failures
…contains vso commands
b21b4b4
to
07a7a23
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue https://portal.microsofticm.com/imp/v5/incidents/details/31000000353897/summary , which describes a vulnerability in Azure Pipelines where malicious input can be injected through Git metadata, not necessarily through built-in pipeline variables.
For example, in the following YAML pipeline code:
$authorEmail = git log -1 --pretty=format:"%ae" Write-Host "Email address of the author is $authorEmail"
Git user email could be updated such as :
git config user.email "##vso[task.setvariable variable=downloadUrl]https://www.evil.com"
This would inject a VSO command into the pipeline runtime and update the Url variable.
As fix:
The code has been updated to include a condition that checks whether the Git author name, email address, or commit message contains any VSO commands, preventing unintended command execution. Also built-in variables 'Build.RequestedForEmail, Release.ReleaseDeploymentRequestedForEmail, Release.ReleaseRequestedForEmail' are included as 'VariablesVulnerableToExecution'
Explain the context or motivation behind this PR. Include links to any related Azure DevOps Work Items or GitHub issues. Fixes AB#2277633
📌 How to link to ADO Work Items
Risk Assessment (Low / Medium / High) : Low
Assess the risk level and justify your assessment. For example: code path sensitivity, usage scope, or backward compatibility concerns.
Unit Tests Added or Updated (Yes / No) : Yes
Indicate whether unit tests were added or modified to reflect the changes.
Additional Testing Performed : Changes tested locally
List manual or automated tests performed beyond unit tests (e.g., integration, scenario, regression).