Skip to content

[BICEP] FinOps Toolkit - Custom resource naming #1105

@plaplainabf

Description

@plaplainabf

⚠️ Problem

The bicep deployment doesn't allow the names of the resources to be set. This means that companies with naming standards can't deploy FinOps using bicep or the accept the resources won't adhere to their naming standards.

🛠️ Solution

Update the bicep code to include parameters for the names of the keyvault, data factory and storage accounts, this means that consumers can generate names using their own bicep naming modules and pass it through to the FinOps Toolkit deployment, providing a repeatable deployment.

ℹ️ Additional context

Looking at the FinOps Toolkit bicep code the main.bicep should be fairly easy to update for the data factory and storage account as there are two variables that are set.
Image

The keyvault name appears to be set within the keyvault.bicep so that would need a parameter defining and the main.bicep updating to pass through said parameter.

I believe parameters can have default values set, so these could be set to what the bicep deployment currently uses, that way it wouldn't break existing deployments.

This was originally posted in the wrong place;
Azure/bicep-registry-modules#3740 (comment)

🙋‍♀️ Ask for the community

We could use your help:

  1. Please vote this issue up (👍) to prioritize it.

Activity

added
Skill: DeploymentResource deployment automation via bicep or terraform
and removed
Needs: Triage 🔍Untriaged issue needs to be reviewed
on Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

OKR: 2.3 FeedbackIssues that are based on the top voted customer feedbackSkill: DeploymentResource deployment automation via bicep or terraformTool: FinOps hubsData pipeline solutionType: Feature 💎Idea to improve the product

Projects

No projects

Relationships

None yet

    Participants

    @flanakin@arthurclares@plaplainabf

    Issue actions

      [BICEP] FinOps Toolkit - Custom resource naming · Issue #1105 · microsoft/finops-toolkit