Add support for calling kiota via standard npx command #6453
+1,417
−316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turned off unnecessary bootstrap in esproj and workflows that is triggering an inappropriate install mid build.
baywet
approved these changes
Apr 14, 2025
garethj-msft
commented
Apr 25, 2025
| @@ -65,8 +70,12 @@ | |||
| "devDependencies": { | |||
| "@types/adm-zip": "^0.5.7", | |||
| "@types/jest": "^29.5.14", | |||
| "eslint": "^9.24.0", | |||
There was a problem hiding this comment.
See if these can come from the shared package.json
garethj-msft
commented
Apr 25, 2025
| "glob": "^11.0.1", | ||
| "jest": "^29.7.0", | ||
| "jest-editor-support": "^32.0.0-beta.1", |
There was a problem hiding this comment.
Remove as it didn't work.
garethj-msft
commented
Apr 25, 2025
| "author": "", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@microsoft/kiota": "file:./microsoft-kiota-1.0.0.tgz" |
There was a problem hiding this comment.
Can we wildcard this.
There was a problem hiding this comment.
Or add a command line option in the test to force it to be 1.0.0
There was a problem hiding this comment.
Hi @garethj-msft, could you share more context on this?
fey101
reviewed
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies heavily on npm infrastructure and existing code to fix #6442