Fix NaN in Results Overview when eval metric score is not a number #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When eval metrics return non-numeric scores (like "❓" for unknown results), the Results Overview table incorrectly shows "NaN" instead of the appropriate fallback value.
Problem
The issue occurs in the
computeOverview
function when:parseScore
function returnsundefined
for these casesms.some((m) => !isNaN(m.score))
incorrectly identifies these as numeric scorersms.reduce((total, m) => total + m.score, 0) / ms.length
includesundefined
values, resulting in NaNExample
Before fix:
After fix:
Solution
Updated the scorer detection and calculation logic to:
typeof m.score === "number" && !isNaN(m.score)
Testing
Verified the fix handles all scenarios correctly:
Fixes #174.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.sheetjs.com
npm install
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.