Cannot use URL for config icon

[jachaussloef]

Windows Terminal version

1.22.11751.0

Windows build number

10.0.26100.4351

Other Software

No response

Steps to reproduce

In settings when you insert a url icon (such as OpenSUSE's https://static.opensuse.org/favicon.ico), after inserting the icon displays normally. When hitting SAVE it reported it was invalid.

Expected Behavior

No response

Actual Behavior

After updating to 1.22.11751.0, URL icon cannot be used as config icon. When first launching after updating it reported that it finds an "invalid" config icon and changed it back to default (which means it was valid before).

[Roger-WIN]

If you have viewed the changelog, you will know that this change was intentional, even though I don't like it either.

[Frulfump]

If you have viewed the changelog, you will know that this change was intentional, even though I don't like it either.

Oh it was unclear that HTTPS was also not allowed from the release note which I read but now I read the PR and it's clear from that.
cc @DHowett

#19044

This pull request adds a filesystem path validator (which accepts images with fully-qualified paths and UNC paths), makes the URI validator reject any web-origin URIs (only file and ms-* are allowable), and suppresses warnings for any images that were not directly set by the user.

I added a feature request to get icons for popular distros here #19078

[ipcjs]

What are the security risks of using URL icons? I don't get it.🙁

[jachaussloef]

Sounds great. Intentionally introducing a bug. (Yes I'll still call it a bug until it's fixed, if not I'll call it a bug forever)