PR description: suggestions

[isidorn]

Refs: microsoft/vscode#114967

Would be cool if in the PR create flow in the Descripiton I could use suggestions to get offered issue numbers, user names etc.. Like we have in other parts of the GH UI in VS Code.
My use case is that in the PR descripiton I would usually say "fixes #ISSUE_NUMBER"

[tanhakabir]

+1 for auto-complete for issue #'s and @'s

[bamurtaugh]

cc @alexr00 wanted to raise awareness that we received github.dev feedback that commenting could be more powerful in GHPRI, including suggestions/auto-converting/hints for issues and usernames, emojis.

[alexr00]

@bamurtaugh commenting in the comments widget has suggestions already. Commenting in the PR overview editor is done in a webview, so we wont ever show suggestions.

[bamurtaugh]

Thanks for the context @alexr00! I see where @ works to suggest a username in the comment widget. Should # suggest an issue or PR number, or : work to suggest an emoji?

Suggestion experience I see on gh.com:

What I see in GHPRI comment widget:

Commenting in the PR overview editor is done in a webview, so we wont ever show suggestions.

Or perhaps if we won't ever show suggestions in the webview, enhancing certain aspects of the comment widget is the outstanding aspect of this feature request, and my comment above is stating the already-known request? Although it sounds like this issue is more oriented around the description.

[alexr00]

I think most operating systems have their own emoji shortcut, so having a VS code specific one feels like overkill/duplication. What do you think?

# to trigger an issue suggestion does work in the comments widget, just not on the first character of the line in markdown. I have pushed a tweak to this to treat comments differently (and to show the completions when the suggest is invoked i.e., not trigger character). You should see this improved in the next nightly build!

[bamurtaugh]

I think most operating systems have their own emoji shortcut, so having a VS code specific one feels like overkill/duplication. What do you think?

That's a good point - issue suggestion/completion is likely the more important component here.

---

I'm trying # in various comment combinations (comments on a specific file, PR overview page, first line in a comment, later lines in a comment), and I don't seem to be getting suggestions in github.dev with GHPRI nightly. Should I be seeing it now?

Example on https://github.dev/bamurtaugh/ExpressApp/pull/5:

On https://github.com/bamurtaugh/ExpressApp/pull/5/files:

Please let me know if I'm missing something!

[alexr00]

@bamurtaugh looks like there were a few more issues that could happen. I've pushed a fix and queued a new pre-release build. Note that GHPRI now uses VS Code's built in pre-release support, and the old Nightly build has been deprecated (as of yesterday).

[bamurtaugh]

@alexr00 I now have only GHPRI stable enabled, v0.32.0. Should I see this change live when I go to https://github.dev/bamurtaugh/ExpressApp/pull/5 and type # in any comment area?

[alexr00]

@bamurtaugh you need to install the pre-release version, which can be done from the extensions view. GHPRI has a "switch to pre-release" (or something similar) button.