Skip to content

Use number badge for padawan notifications #7070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025
Merged

Use number badge for padawan notifications #7070

merged 4 commits into from
Jun 24, 2025

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jun 24, 2025

also promote the "copilot on my behalf" query to be a real query

also promote the "copilot on my behalf" query to be a real query
@alexr00 alexr00 self-assigned this Jun 24, 2025
@alexr00 alexr00 enabled auto-merge (squash) June 24, 2025 10:31
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 24, 2025
lszomoru
lszomoru previously approved these changes Jun 24, 2025
@lszomoru
Copy link
Member

@alexr00, PR build is 🔴

sandy081
sandy081 previously approved these changes Jun 24, 2025

await this._getStateChanges(query);

setTimeout(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This timeout might leak if the CopilotPRWatcher is disposed!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching!

@alexr00 alexr00 merged commit 75ecee0 into main Jun 24, 2025
3 checks passed
@alexr00 alexr00 deleted the alexr00/brief-mule branch June 24, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants