Polishing session view #7075
Merged
Polishing session view #7075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mjbvz
commented
Jun 25, 2025
mjbvz
commented
- Adds back button
- Adds open on web command
- Use codicons
- Fix overflow
- Add state restore
- Adds back button - Adds open on web command - Use codicons - Fix overflow - Add state restore
DonJayamanne
approved these changes
Jun 25, 2025
alexr00
reviewed
Jun 25, 2025
Comment on lines
+174
to
+180
| webviewPanel.onDidChangeViewState(() => { | ||
| if (webviewPanel.active) { | ||
| this._activePanel = logView; | ||
| } else if (this._activePanel === logView && !webviewPanel.active) { | ||
| this._activePanel = undefined; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Looks like this listener can leak
Comment on lines
+49
to
+51
| onClick={() => { | ||
| vscode.postMessage({ type: 'openPullRequestView' }); | ||
| }}> |
There was a problem hiding this comment.
You could also just use a link and use the PR URI format.
vscode-pull-request-github/src/common/uri.ts
Lines 543 to 546 in 1e2ed4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.