Add Ctrl/Cmd+click support to open PR changes and session logs in second editor group #7139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rebornix <876920+rebornix@users.noreply.github.com>
Co-authored-by: rebornix <876920+rebornix@users.noreply.github.com>
…ond editor group Co-authored-by: rebornix <876920+rebornix@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
rebornix
June 28, 2025 05:22
rebornix
approved these changes
Jun 30, 2025
DonJayamanne
approved these changes
Jun 30, 2025
alexr00
reviewed
Jun 30, 2025
| @@ -105,11 +105,16 @@ function Title({ title, titleHTML, number, url, inEditMode, setEditMode, setCurr | |||
| function ButtonGroup({ isCurrentlyCheckedOut, canEdit, isIssue, repositoryDefaultBranch, setEditMode }) { | |||
| const { refresh, copyPrLink, copyVscodeDevLink, openChanges } = useContext(PullRequestContext); | |||
|
|
|||
| const handleOpenChangesClick = (e: React.MouseEvent) => { | |||
| const openToTheSide = e.ctrlKey || e.metaKey; | |||
There was a problem hiding this comment.
On Windows, the default to-the-side modifier is alt as far as I know.
Comment on lines
+1289
to
1298
| if (openToTheSide) { | ||
| if (vscode.window.tabGroups.all.length < 2) { | ||
| await vscode.commands.executeCommand('workbench.action.splitEditor'); | ||
| } | ||
|
|
||
| await vscode.commands.executeCommand('workbench.action.focusSecondEditorGroup'); | ||
| } | ||
|
|
||
| return vscode.commands.executeCommand('vscode.changes', vscode.l10n.t('Changes in Pull Request #{0}', pullRequestModel.number), args); | ||
| } |
There was a problem hiding this comment.
It would be better to fix the vscode.changes command to properly handle the usual open arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Ctrl/Cmd+click functionality to the "Open Changes" and "View Session Log" buttons in the PR detail webview. When users hold Ctrl (Windows/Linux) or Cmd (macOS) while clicking these buttons, the views will open in the second editor group instead of the current one.
Changes Made
Frontend (Webviews)
webviews/components/header.tsx: Added click handler for "Open Changes" button to detect modifier keys and updated tooltipwebviews/components/timeline.tsx: Enhanced session log buttons in Copilot events to support modifier key detectionwebviews/common/context.tsx: UpdatedopenChanges()andopenSessionLog()methods to accept optionalinSecondEditorGroupparameterBackend
src/github/pullRequestOverview.ts: Modified message handlers to process the newinSecondEditorGroupparametersrc/github/pullRequestModel.ts: EnhancedopenChanges()to automatically split editor and focus second group when requestedsrc/view/sessionLogView.ts: Updated session log viewer to open inViewColumn.Twowhen requestedTesting
src/test/github/pullRequestOverview.test.ts: Added focused unit tests to verify both features work correctly with the second editor group functionalityUser Experience
Before
After
Implementation Details
e.ctrlKey || e.metaKey) for cross-platform modifier key detectionworkbench.action.splitEditorandworkbench.action.focusSecondEditorGroupcommandsvscode.ViewColumn.Twoparameter increateWebviewPanel()Testing
The implementation includes comprehensive unit tests and has been designed to be easily testable in a live VS Code environment with PRs that have file changes and Copilot session events.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.