feat: copy Linux packages to sign them with a new key #252529
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will have a detailed review in debt week, but primarily we cannot republish the el8 package as el10, the release parameter needs to be bumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the main publishing pipeline to create copies of the built Debian and RPM packages so that it can sign them with a new key from packages.microsoft.com (PMC). The new key is required for us to upload the packages to new PMC repositories, which in turn would allow Linux users on newer platforms to install VS Code without security warnings.
However, this change will not immediately make newer packages available to users because the artifacts will have to be made available on the builds and/or VS Code website.
Questions