improve discoverability of terminal suggest configuration #252543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2025
Tyriar
previously requested changes
Jun 27, 2025
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminal.suggest.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/common/terminal.suggest.ts
Outdated
Show resolved
Hide resolved
|
@Tyriar i've added a reset command and will make an issue to remove that after testing |
Tyriar
previously requested changes
Jun 30, 2025
Comment on lines
312
to
327
| registerTerminalAction({ | ||
| id: TerminalSuggestCommandId.ResetDiscoverability, | ||
| title: localize2('workbench.action.terminal.resetDiscoverability', 'Reset Discoverability'), | ||
| f1: true, | ||
| precondition: ContextKeyExpr.and( | ||
| ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated), | ||
| TerminalContextKeys.focus, | ||
| TerminalContextKeys.isOpen, | ||
| ContextKeyExpr.equals(`config.${TerminalSuggestSettingId.Enabled}`, true) | ||
| ), | ||
| run: (c, accessor) => { | ||
| const storageService = accessor.get(IStorageService); | ||
| storageService.store(TERMINAL_SUGGEST_DISCOVERABILITY_KEY, false, StorageScope.APPLICATION, StorageTarget.MACHINE); | ||
| storageService.store(TERMINAL_SUGGEST_DISCOVERABILITY_COUNT_KEY, 0, StorageScope.APPLICATION, StorageTarget.MACHINE); | ||
| } | ||
| }); |
There was a problem hiding this comment.
We can probably do without this? A command named Terminal: Reset Discoverability just raises questions imo.
There was a problem hiding this comment.
will be very helpful for testing
There was a problem hiding this comment.
That's fine if we remove. You could also instruct the tester to use --user-data-dir ./tmp to reset it, though that wouldn't work if you're testing syncing.
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestShownTracker.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestShownTracker.ts
Show resolved
Hide resolved
Tyriar
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #252321
The
Learn Moreaction is highlighted for the first ten shows or for the first time the widgt shows for 10 seconds per machine.To do: