[engineering] make boilerplate stripper differentiate between tsc and esbuild #252597
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… esbuild typescript compiler emits a method named `__decorate` [1] esbuild emits a different method named `__decorateClass` [2] ensure the regex differentiates the two and does not clobber esbuild outputs [1] https://github.com/microsoft/TypeScript/blob/02672d281c26e561708127da1d8d1a6cae45fee2/src/compiler/factory/emitHelpers.ts#L730-L742 [2] https://github.com/evanw/esbuild/blob/f4159a7b823cd5fe2217da2c30e8873d2f319667/internal/runtime/runtime.go#L550-L561
|
No, the point is to update the regex to fix the clash. |
| @@ -18,7 +18,7 @@ export function removeAllTSBoilerplate(source: string) { | |||
| const BOILERPLATE = [ | |||
| { start: /^var __extends/, end: /^}\)\(\);$/ }, | |||
| { start: /^var __assign/, end: /^};$/ }, | |||
| { start: /^var __decorate/, end: /^};$/ }, | |||
There was a problem hiding this comment.
{ start: /^var __decorate(?=\()/, end: /^};$/ }, // TypeScript's __decorate
{ start: /^var __decorateClass\b/, end: /^};$/ }, // esbuild's __decorateClass
This should ensure they don't clash and work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript compiler emits a method named
__decorate[1]esbuild emits a different method named
__decorateClass[2]ensure the regex differentiates the two and does not clobber esbuild outputs
[1] https://github.com/microsoft/TypeScript/blob/02672d281c26e561708127da1d8d1a6cae45fee2/src/compiler/factory/emitHelpers.ts#L730-L742
[2] https://github.com/evanw/esbuild/blob/f4159a7b823cd5fe2217da2c30e8873d2f319667/internal/runtime/runtime.go#L550-L561