Add asHex proposal to ThemeColor API #252631
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an
asHex
proposal to theThemeColor
API. The change adds a new method to allow consumers to retrieve the hexadecimal representation of aThemeColor
instance, improving theme color interoperability and making it easier for extensions and core features to work with color values in a standard hex format.Changes
vscode.proposed.themeColorAsHex.d.ts
with the new API definitionextHost.protocol.ts
to support theme color resolution via RPC$getColorAsHex
method toMainThreadTheming
using existing theme serviceasHex()
method toThemeColor
class with proper error handlingextHost.api.impl.ts
to register theming service for ThemeColor accessAPI Design
Usage Example
Key Features
undefined
for colors that cannot be resolvedUse Cases Enabled
Implementation Notes
The implementation leverages VS Code's existing color infrastructure:
Color.Format.CSS.formatHex()
for consistent formattingNo breaking changes are introduced. The proposal follows VS Code coding guidelines and API conventions.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.