feat: time the different search providers #252700
Open
+59
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Jun 27, 2025
| // Only log the elapsed time if there are actual results. | ||
| if (result && result.filterMatches.length > 0) { | ||
| const elapsed = this.stopWatch.elapsed(); | ||
| this.logSearchPerformance(LLM_RANKED_SEARCH_PROVIDER_NAME, elapsed); |
There was a problem hiding this comment.
There are a few reasons why a user wouldn't get any LLM_RANKED results, so we wrap this code in an if statement for now.
| if (token.isCancellationRequested) { | ||
| // Handle cancellation like this because cancellation is lost inside the search provider due to async/await | ||
| return null; | ||
| } | ||
|
|
||
| // Only log the elapsed time if there are actual results. | ||
| if (result && result.filterMatches.length > 0) { |
There was a problem hiding this comment.
I have added this if statement to be consistent with the one for LLM_RANKED results.
It is probably safe to remove the if statement for local and TF-IDF search providers, and to keep it for the less-available embeddings search provider, but that complicates the if statement and could alter the reported times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.