Add SecretStorage.keys() as proposed API
#252804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @TylerLeonhardt |
gjsjohnmurray
added a commit
to gjsjohnmurray/vscode-extension-samples
that referenced
this pull request
Jun 28, 2025
Useful for testing PR microsoft/vscode#252804
|
https://github.com/gjsjohnmurray/vscode-extension-samples/tree/test-vscode-252804 provides a way of testing this by adding the following commands to authenticationprovider-sample:
Run the first one or more times, then run the second to see the keys, then the third to delete them all. |
|
Any chance of getting this into this week's endgame? |
|
Im on vacation til the 17th so it won't make this endgame |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #196616 by adding
SecretStorage.keys()behind asecretStorageKeysproposed API gate.