Skip to content

Add 2 missing calls to cancelAISearch #252808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gjsjohnmurray
Copy link
Contributor

@osortega I noticed that a few of the places where cancelSearch is being called don't also call cancelAISearch. This PR corrects that, in the hope it might fix the problem reported in several issues since 1.101 shipped, in which edits to the Find field take a long time to affect the search results.

@bpasero
Copy link
Member

bpasero commented Jun 29, 2025

Maybe related? #252746

@gjsjohnmurray
Copy link
Contributor Author

@osortega I am very glad to #253489 merged. Do you think this PR is also relevant, even if only for people who opt to run the AI search every time?

@osortega
Copy link
Contributor

osortega commented Jul 2, 2025

@osortega I am very glad to #253489 merged. Do you think this PR is also relevant, even if only for people who opt to run the AI search every time?

I think this PR is still relevant, but I will add it for the next milestone given that we are on endgame already and I want to be extra careful

@osortega osortega added this to the July 2025 milestone Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants