-
-
Notifications
You must be signed in to change notification settings - Fork 208
Description
- I don't see the node-proxy-agent dependency registered in package.json. Is this truly the HTTP client framework that corepack uses to download components when running
corepack install
? - node-proxy-agent is a dead project with a successor "proxy-agents". When can we replace the dead proxy dependency with a live one?
- Despite both corepack and node-proxy-agent documenting uppercase
HTTP_PROXY
,HTTPS_PROXY
environment variables, on my machine only the lowercase oneshttp_proxy
,https_proxy
have any effect on whether package installation occurs through a proxy or not. - Unlike many other applications, including NPM, corepack fails when presented with the proxy URL's
http://
orhttps://
(no address). The user's intention here is to indicate that no proxy should be used. And these URL values make larger configuration scripting a lot easier. - Why not use the same HTTP client as NPM, so that proxy configuration at least behaves identically? Then any questions about configuration can simply link to official NPM documentation. Smaller technology stack, smaller attack surface, less maintenance.
Metadata
Metadata
Assignees
Labels
No labels
Activity
aduh95 commentedon Feb 6, 2025
I very much doubt using npm stack would decrease the size of bundle and the attack surface, quite the contrary.
corepack install
is not a thing (yet), but no, we moved away from it with #365.I've opened #636 to address this.
That feels something that should be reported upstream, but I'm not opposed to fix it downstream if someone sends a PR.
proxy-from-env
toEnvHttpProxyAgent
#640aduh95 commentedon Feb 7, 2025
BTW any reason you're not using
NO_PROXY
for that?