Skip to content

feature request: built-in pnpm modules cache manager #19

Closed
@septs

Description

@septs

Built-in pnpm modules cache manager

Reduce boilerplate statements

e.g:

- uses: pnpm/action-setup@v2.0.1
  with:
    version: latest
    cache: true

Activity

KSXGitHub

KSXGitHub commented on Jul 30, 2021

@KSXGitHub
Collaborator

I have no objection, but I'm busy right now, so I will accept pull requests.

dominikg

dominikg commented on Aug 5, 2021

@dominikg

note, action setup-node has added pnpm caching too https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

and documents using this action to install pnpm

oscard0m

oscard0m commented on Nov 6, 2021

@oscard0m

Should we close this issue considering setup-node is giving support to it?


@dominikg do you think it would have sense to ask for pnpm to be included by default in steup-node as it does with npm and yarn ?

dominikg

dominikg commented on Nov 6, 2021

@dominikg

I don't think setup node handles installation of package managers other than npm that comes with the specified node version. iirc yarn is included as part of the hosted runner virtual env, but they declined to include pnpm

actions/runner-images#2279

This action or a run step npm i -g pnpm work reasonably fast and are flexible for users so i'm not sure there is a lot of demand/support for a builtin version

oscard0m

oscard0m commented on Nov 7, 2021

@oscard0m

I don't think setup node handles installation of package managers other than npm that comes with the specified node version. iirc yarn is included as part of the hosted runner virtual env, but they declined to include pnpm

actions/virtual-environments#2279

Yep, I was thinking of using the same approach as yarn (I didn't know about actions' virtual environment). Thanks for this input here @dominikg.


With this said, should we close this issue @septs @KSXGitHub ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @dominikg@oscard0m@septs@KSXGitHub

      Issue actions

        feature request: built-in pnpm modules cache manager · Issue #19 · pnpm/action-setup