-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[p5.js 2.0 Bug Report]: p5.RendererGL.js Unit Test fails #7869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you! |
Is this flaky in some way, e.g. if you run just that one test file with |
Hey Dave, yes definitely flaky. It hasn't failed yet on my side when running it independently, and it fails intermittently when running it in combination with other tests. |
Another thing to test could be parallelism. It looks like by default vitest runs multiple test files in parallel, and on some systems WebGL tests might be too heavy to do that within the 1s timeout? So some things to test could be:
|
Hi Dave, I'll go ahead and test both scenarios. I've regularly seen this particular test fail more often during repeated test runs, as system load progressively increases. That said, I've also occasionally observed failures when launching a first test run on a quiet machine (albeit in parallel with other tests). I shall test without parallelism first to see if that solves the issue. Otherwise, I suspect increasing the test timeout will help. I'll report back on my findings! |
Uh oh!
There was an error while loading. Please reload this page.
Most appropriate sub-area of p5.js?
p5.js version
2.0.2
Web browser and version
Chrome, 137.0.7151.55
Operating system
MacOS Sequoia 15.1.1
Steps to reproduce this
Steps:
npx vitest run
.tint should be reset after draw loop
test in thetint() in WEBGL mode
suite (path:test/unit/webgl/p5.RendererGL.js
) is flaky and intermittently times out with the error shown below.Snippet:
Screenshot:
I have not been able to analyse root cause yet or attempt a fix.
The text was updated successfully, but these errors were encountered: