Fix structuring of attrs class that inherit from typing/collections.abc generic type aliases #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….abc types still works This reproduces issue python-attrs#654: AttributeError: type object 'Iterable' has no attribute '__parameters__'
|
Don't forget to add a changelog entry, and I can release this as v25.1.1 soon. |
|
yes thanks, I can do in a bit after lunch. |
anthrotype
force-pushed
the
fix-generic-alias-no-parameters
branch
from
9d37a51 to
6346106
Compare
done |
|
Great job on this. Please add a link to the issue too to the CHANGELOG and I will release this in the evening. |
…parameters__ attributes Reverts python-attrs@2fe721e
anthrotype
force-pushed
the
fix-generic-alias-no-parameters
branch
from
6346106 to
3ca2b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654
The first commit reproduces the error
AttributeError: type object 'Iterable' has no attribute '__parameters__'.I will follow up with the actual fix.