Skip to content

full # noqa support #185

@jakkdl

Description

@jakkdl

Making a separate issue from #181 to track all current issues/TOODs with # noqa

  • 0 Respect noqa-trio as a way to have full flake8-noqa support
  • 1 Don't autofix noqa'd errors
    • This might not be a huge issue atm, but is a must going forward as more visitors get autofix support.
  • 2 Raise error if invalid (or not enabled) TRIO error code is noqa'd.
    • Not a must, and sort of covered by flake8-noqa. But if it's a simple logic addition there's not much reason not to.
  • 3 raise noqad errors when running as a plugin noqa now correctly ignored when running as plugin. ast-based visitors… #188
    • otherwise we're fully incompatible with flake8-noqa
  • 4 support --disable-noqa
  • 5 document current level of [in]compatibility with flake8-noqa
  • 6 respect # noqa in ast visitors. noqa now correctly ignored when running as plugin. ast-based visitors… #188
  • 7 check that # noqa comments are resilient to line numbers changing due to autofix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions