Document that PyType_GetModuleByDef returns a borrowed reference #135666
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
added
needs backport to 3.13
kumaraditya303
approved these changes
Jun 18, 2025
neonene
reviewed
Jun 18, 2025
| @@ -282,6 +282,10 @@ Type Objects | |||
| and other places where a method's defining class cannot be passed using the | |||
| :c:type:`PyCMethod` calling convention. | |||
| The returned reference is :term:`borrowed <borrowed reference>` from *type*, | |||
| and will be valid as long as you hold a reference to *type*. | |||
| Do not release it with :c:func:`Py_DECREF` or similar. | |||
There was a problem hiding this comment.
I prefer L287 to have "otherwise" or something if hold a reference implies a Py_INCREF() in the previous line.
There was a problem hiding this comment.
Sorry, I completely misread that, mixing the module and the type. LGTM.
There was a problem hiding this comment.
No worries. Thanks for checking!
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 19, 2025
…honGH-135666) (cherry picked from commit 140731ff671395fb7a869c2784429c14dc83fb27) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-135701 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 19, 2025
…honGH-135666) (cherry picked from commit 140731f) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-135702 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--135666.org.readthedocs.build/