Skip to content

gh-135645: Added supports_isolated_interpreters to sys.implementation #135667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 18, 2025

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
Copy link
Member Author

Thank you, @vstinner! I would like to get a review from:

  • @ericsnowcurrently as a code-owner
  • and from @hugovk as the RM, because this is techincally a feature, and now it is a feature freeze

@sobolevn sobolevn requested a review from hugovk June 18, 2025 14:55
@sobolevn sobolevn added the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
@vstinner
Copy link
Member

and from @hugovk as the RM, because this is techincally a feature, and now it is a feature freeze

PEP 734 got an exception to be added to Python 3.14 after the feature freeze, no?

@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

sobolevn and others added 2 commits June 18, 2025 22:18
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 18, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 028b498 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135667%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 18, 2025
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 19, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 5fe139c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135667%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants