-
Notifications
You must be signed in to change notification settings - Fork 125
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Bug
When I click on "view file", I expect the file to be opened. Instead I see 404 GitHub page.
The reason is described in Analysis section.
React Native versions
all
Steps to reproduce
See above.
Describe what you expected to happen:
-
I click on "view file".
-
I expect the file to be opened.
Analysis
In GitHub url, "Rn" prefix is missing, instead of "RnDiffApp" only "DiffApp" is present. This is due to the fact, that GitHub deliver diffs without prefixed and gitdiff-parser
library currently only supports diffs with prefixes.
Solution proposals (cleanest/highest effort -> dirtiest/lowest effort):
- Find a way to fetch diffs from GitHub with git prefixes (
a/
,b/
) - Make
gitdiff-parser
support diffs without prefixes (Add support for diffs created with --no-prefix option ecomfe/gitdiff-parser#21) - Quick&Dirty: Replace DiffApp with RnDiffApp in both
DownloadFileButton
andViewFileButton
components.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working