Skip to content

Click on view file or download binary leads to 404 github page #292

@skaldo

Description

@skaldo

Bug

When I click on "view file", I expect the file to be opened. Instead I see 404 GitHub page.
The reason is described in Analysis section.

React Native versions

all

Steps to reproduce

See above.

Describe what you expected to happen:

  1. I click on "view file".

  2. I expect the file to be opened.

Analysis

In GitHub url, "Rn" prefix is missing, instead of "RnDiffApp" only "DiffApp" is present. This is due to the fact, that GitHub deliver diffs without prefixed and gitdiff-parser library currently only supports diffs with prefixes.

Solution proposals (cleanest/highest effort -> dirtiest/lowest effort):

  1. Find a way to fetch diffs from GitHub with git prefixes (a/, b/)
  2. Make gitdiff-parser support diffs without prefixes (Add support for diffs created with --no-prefix option ecomfe/gitdiff-parser#21)
  3. Quick&Dirty: Replace DiffApp with RnDiffApp in both DownloadFileButton and ViewFileButton components.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions