Skip to content

Android diffs don't update with provided app package #382

Closed
@frankcalise

Description

@frankcalise

Bug

When viewing the Android diffs when providing an app package (overriding the com.rndiffapp placeholder), the diff still holds the value of com.rndiffapp in files such as build.gradle, MainActivity.java, MainActivity.kt etc

Steps to reproduce

Describe what you expected to happen:

  1. Enter in a value for What's your app package?, such as com.myapp

  2. Set versions to 0.72.10 to 0.74.0-rc.6

  3. Press Show me how to upgrade!

  4. Observe that the only place to find your provided string is the input box.

  5. Observe that com.rndiffapp is still on screen in the following files

  • android/app/build.gradle
  • android/app/src/main/java/com/myapp/MainActivity.kt (and MainActivity.java - this should so be com/rndiffapp/MainActivity.kt I think?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions