Skip to content

LLVM CFI integration being undocumented complicates further codegen dev #143751

Open
@workingjubilee

Description

@workingjubilee

When #105452 and related PRs added a bunch of parameters to things like BuilderMethods::call, it did not include explanations of what those parameters were for. Namely, that they were for CFI tracking and that they were not relevant to actual ABI handling.

The knowledge exists in the heads of Rust contributors, of course, so we can just talk to each other... except for how it is in the heads of Rust contributors who are very busy because they have a lot of different things they have to attend to because they're the only one who knows the thing.

I would like to see these just-for-CFI changes documented and ideally cleaned up so we are no longer passing ambiguous details around which are secretly-only-advisory-except-if-you-are-doing-CFI-related-codegen-in-which-case-it-is-critical.

cc @rcvalle

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions