[explicit-resource-management] Add remaining tests specific to await using statement syntax
#4481
Conversation
test/language/statements/await-using/syntax/await-using-allowed-at-top-level-of-module.js
Outdated
Show resolved
Hide resolved
...t-using/syntax/block-scope-syntax-await-using-declarations-mixed-with-without-initializer.js
Show resolved
Hide resolved
| asyncTest(async function () { | ||
| await assert.throwsAsync(TypeError, async function() { | ||
| for (await using i = 0; i < 1; i++) {} | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Should this not result in a SyntaxError, due to https://tc39.es/ecma262/#sec-let-and-const-declarations-static-semantics-early-errors?
There was a problem hiding this comment.
Early errors do not forbid this. await using i = 0 is allowed in the ForInitializer of a for statement. The error raised is due to the assignment in i++ which attempts to modify an immutable binding.
There was a problem hiding this comment.
OK, got it. I noticed you changed this to expect a ReferenceError instead of a TypeError, though. Are you sure that is correct? I get a TypeError from modifying another immutable binding such as for (const x of [1, 2, 3]) { x++ }.
| /*--- | ||
| esid: pending | ||
| description: > | ||
| await using: invalid assignment in Statement body |
There was a problem hiding this comment.
It'd be good to note in the info that the error is thrown in CreateDisposableResource
There was a problem hiding this comment.
The error raised is due to the assignment in x++ which attempts to modify an immutable binding.
There was a problem hiding this comment.
Same question about ReferenceError.
rbuckton
force-pushed
the
explicit-resource-management-await-using-syntax
branch
from
1c7f1de to
bd747be
Compare
In an effort to make review more manageable, this extracts the remaining tests specific to
await usingstatement syntax from #3866