-
Notifications
You must be signed in to change notification settings - Fork 494
[explicit-resource-management] Add remaining tests specific to using statement syntax #4483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[explicit-resource-management] Add remaining tests specific to using statement syntax #4483
Conversation
test/language/statements/using/syntax/using-invalid-for-using-of-of.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I just reviewed the await using
PR, this went fairly quickly. Please apply all the comments there to this PR as well.
d1528c9
to
f56e3f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question to resolve, otherwise merge ready.
features: [explicit-resource-management] | ||
---*/ | ||
|
||
assert.throws(TypeError, function() { | ||
assert.throws(ReferenceError, function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question about ReferenceError vs TypeError as in the await using
PR.
features: [explicit-resource-management] | ||
---*/ | ||
|
||
assert.throws(TypeError, function() { | ||
assert.throws(ReferenceError, function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
In an effort to make review more manageable, this extracts the remaining tests specific to
using
statement syntax from #3866