Skip to content

Update GitHub workflow actions to v4 for cache compatibility #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

mik-tf
Copy link
Contributor

@mik-tf mik-tf commented Apr 8, 2025

Description

This PR updates all GitHub Actions workflows to use actions/setup-node@v4 and actions/checkout@v3 to be compatible with GitHub's new cache architecture that was deployed in February 2025.

Related Issue

Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, why do you use actions/checkout@v3 in some files while others have actions/checkout@v4 like in grid_client_test.yml?

@mik-tf
Copy link
Contributor Author

mik-tf commented Apr 10, 2025

@amiraabouhadid Good point. I updated them all to v4. Thanks.

@0oM4R
Copy link
Contributor

0oM4R commented Apr 15, 2025

So check out to be v4, or v3?
Also I see some workflows still on v2 on some workflow files, for example this file
I suggest to use v4 as it is a newer version
image

@mik-tf
Copy link
Contributor Author

mik-tf commented Apr 15, 2025

Good point. I updated all that I found to v4. Lmk if it's OK. Thanks.

EDIT:

  • All should be to v4, except those two, which are higher versions:
  • ./.github/workflows/playground_selenium.yaml: uses: actions/setup-python@v5
  • ./.github/workflows/publish_arm.yml: uses: actions/github-script@v6

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For QA: some workflow can't be tested untill release

@samaradel
Copy link
Contributor

As actions/setup-node#1275 (comment), we need to merge it ASAP

@samaradel samaradel merged commit 2186db2 into development Apr 16, 2025
9 of 10 checks passed
@samaradel samaradel deleted the update-github-workflows branch April 16, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 [Bug]: GitHub Actions Workflow Update Required: Cache Service Architecture Migration
4 participants