Skip to content

Updating tests flists #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2025
Merged

Conversation

khaledyoussef24
Copy link
Contributor

Description

using the dashboard flists library in the tests
#4127

Changes

List of changes this PR includes

Related Issues

List of related issues

Tested Scenarios

A list of scenarios tried to match the deliverables

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

  • Preliminary Checks
    • Does it completely address the issue linked?
    • What about edge cases?
    • Does it meet the specified acceptance criteria?
    • Are there any unintended side effects?
    • Does the PR adhere to the team's coding conventions, style guides, and best practices?
    • Does it integrate well with existing features?
    • Does it impact the overall performance of the application?
    • Are there any bottlenecks or slowdowns?
    • Has it been optimized for efficiency?
    • Has it been adequately tested with unit, integration, and end-to-end tests?
    • Are there any known defects or issues?
    • Is the code well-documented?
    • Are changes to documentation reflected in the code?

UI Checks:

  • UI Checks
    • If a UI design is provided/ does it follow it?
    • Does every button work?
    • Is the data displayed logical? Is it what you expected?
    • Does every validation work?
    • Does this interface feel intuitive?
    • What about slow network? Offline?
    • What if the gridproxy/graphql/chain is failing?
    • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code Quality Checks
    • Code formatted/linted? Are there unused imports? .. etc
    • Is there redundant/repeated code?
    • Are there conditionals that are always true or always false?
    • Can we write this more concisely?
    • Can we reuse this code? If yes, where?
    • Will the changes be easy to maintain and update in the future?
    • Can this code become too complex to understand for other devs?
    • Can this code cause future integration problems?

Testing Checklist

  • Does it Meet the specified acceptance criteria.
  • Test if changes can affect any other functionality.
  • Tested with unit, integration, and end-to-end tests.
  • Tested the un-happy path and rollback scenarios.
  • Documentation updated to meet the latest changes.
  • Check automated tests working successfully with the changes.
  • Can be covered by automated tests.

General Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring
  • Screenshots/Video attached (needed for UI changes)

@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Jun 2, 2025

please add issue link in the related issue field and list the changes along with the test scenarios

Copy link
Contributor

@samaradel samaradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are hard-coded flists that still exist in gateways, qsfs, workload, zmachine-light, and zmachine tests

@xmonader
Copy link
Contributor

@khaledyoussef24 follow up here please

@khaledyoussef24
Copy link
Contributor Author

@amiraabouhadid it is related to this #4127

@khaledyoussef24
Copy link
Contributor Author

khaledyoussef24 commented Jun 15, 2025

changes are done for the flists that exists in gateways, qsfs, workload, zmachine-light, and zmachine tests

@@ -176,7 +177,7 @@ test("TC1237 - Gateways: Expose a VM Over Gateway", async () => {
memory: memory,
rootfs_size: rootfsSize,
disks: disks,
flist: "https://hub.grid.tf/tf-official-vms/ubuntu-24.04-latest.flist",
flist: FLISTS.MICROVMS_UBUNTU_24.flist,
entrypoint: "/usr/bin/python3 -m http.server --bind ::",
Copy link
Contributor

@samaradel samaradel Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be replaced too? the entrypoint I mean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this is different from the entrypoint used in the flists helper file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flists entry points are updated from the Dockerfiles, please verify with the ops team

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked with the ops and the gateway would work fine with this entry point

I can also add the gateway entry point to the helpers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if they agree with this one, please update and test it

@khaledyoussef24
Copy link
Contributor Author

fixed gateway flist and adding it to helpers and fixed coflicts

@samaradel
Copy link
Contributor

@khaledyoussef24 while fixing the conflicts, there are many unrelated changes are now exist, please revert

@khaledyoussef24 khaledyoussef24 force-pushed the development-updating-tests-flist branch from 97fd55a to 0cefed6 Compare July 3, 2025 12:08
@khaledyoussef24
Copy link
Contributor Author

@samaradel fixed them, you may recheck. sorry for being late was having a planned leaves for this week

Copy link
Contributor

@samaradel samaradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@khaledyoussef24 khaledyoussef24 merged commit 1c74933 into development Jul 7, 2025
10 checks passed
@khaledyoussef24 khaledyoussef24 deleted the development-updating-tests-flist branch July 7, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants