-
Notifications
You must be signed in to change notification settings - Fork 8
Updating tests flists #4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tests flists #4199
Conversation
please add issue link in the related issue field and list the changes along with the test scenarios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are hard-coded flists that still exist in gateways
, qsfs
, workload
, zmachine-light
, and zmachine
tests
@khaledyoussef24 follow up here please |
@amiraabouhadid it is related to this #4127 |
changes are done for the flists that exists in gateways, qsfs, workload, zmachine-light, and zmachine tests |
@@ -176,7 +177,7 @@ test("TC1237 - Gateways: Expose a VM Over Gateway", async () => { | |||
memory: memory, | |||
rootfs_size: rootfsSize, | |||
disks: disks, | |||
flist: "https://hub.grid.tf/tf-official-vms/ubuntu-24.04-latest.flist", | |||
flist: FLISTS.MICROVMS_UBUNTU_24.flist, | |||
entrypoint: "/usr/bin/python3 -m http.server --bind ::", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be replaced too? the entrypoint I mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this is different from the entrypoint used in the flists helper file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flists entry points are updated from the Dockerfiles, please verify with the ops team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked with the ops and the gateway would work fine with this entry point
I can also add the gateway entry point to the helpers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if they agree with this one, please update and test it
fixed gateway flist and adding it to helpers and fixed coflicts |
@khaledyoussef24 while fixing the conflicts, there are many unrelated changes are now exist, please revert |
97fd55a
to
0cefed6
Compare
@samaradel fixed them, you may recheck. sorry for being late was having a planned leaves for this week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
Description
using the dashboard flists library in the tests
#4127
Changes
List of changes this PR includes
Related Issues
List of related issues
Tested Scenarios
A list of scenarios tried to match the deliverables
Documentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist