Reduce contracts and deployments loading time #4233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle migrations in parallel if needed - Add grid client cache - Add batch processing utility - Create grid clients in parallel with caching - Load contracts and node IDs in parallel for each machine - Process consumptions in batches - Process wireguard configs in batches
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
0oM4R
reviewed
Jun 22, 2025
| @@ -188,35 +187,82 @@ const loading = ref(false); | |||
|
|
|||
| onMounted(loadDeployments); | |||
| async function loadDeployments() { | |||
| const start = performance.now(); | |||
There was a problem hiding this comment.
this is not needed in the code
There was a problem hiding this comment.
and pleaes check all other performance related logs
There was a problem hiding this comment.
I know, it's for you guys to test performance. If it's ok, I'll remove it before merge
0oM4R
requested changes
Jun 22, 2025
| @@ -188,35 +187,82 @@ const loading = ref(false); | |||
|
|
|||
| onMounted(loadDeployments); | |||
| async function loadDeployments() { | |||
| const start = performance.now(); | |||
There was a problem hiding this comment.
and pleaes check all other performance related logs
| }); | ||
| loading.value = false; | ||
| async function fetchClusterDetails(item: any) { | ||
| if (item.detailsLoading || (item.billing !== undefined && item.wireguard !== undefined)) return; |
| const chunk1 = await loadVms(grid!); | ||
| if (chunk1.count > 0 && migrateGateways) { | ||
| await migrateModule(grid!.gateway); | ||
| const [chunk1, chunk2, chunk3] = await Promise.all([ |
There was a problem hiding this comment.
I suggest using allsettled to avoid errors on partall request error
| } | ||
| }); | ||
| const items = await Promise.all(promises); | ||
|
|
||
| const items = await Promise.all(machinePromises); |
There was a problem hiding this comment.
also here we shouldn't use promise.all
|
|
||
| const BATCH_SIZE = 10; | ||
| const consumptions = await batchProcess(vms, BATCH_SIZE, async batch => { | ||
| return Promise.all( |
There was a problem hiding this comment.
same here should use allsettled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deployments:
Contracts:
Changes
Before: deployments loading time takes around 20 to 25 seconds
After: deployments loading time takes around 15 to 20 seconds
Related Issues
Tested Scenarios
Check deployments loading
Time takenin the console for deployments and contractsDocumentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist