Skip to content

Add KYC alert for all solutions and SSH alert #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Jun 23, 2025

Description

Describe the changes introduced by this PR and what does it affect

Changes

Add KYC and SSH keys alert for all solutions

Related Issues

Tested Scenarios

  • Check the KYC alert for all solutions
  • Check the SSH alert for all solutions

Updated:

  • Test if the messages still exist for the solution, ensuring the SSH key has not been deleted.
  • Test that the SSH messages disappear in case multiple SSH and key message still exists.
  • Test after kyc process is done, all messages disappear.

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

  • Preliminary Checks
    • Does it completely address the issue linked?
    • What about edge cases?
    • Does it meet the specified acceptance criteria?
    • Are there any unintended side effects?
    • Does the PR adhere to the team's coding conventions, style guides, and best practices?
    • Does it integrate well with existing features?
    • Does it impact the overall performance of the application?
    • Are there any bottlenecks or slowdowns?
    • Has it been optimized for efficiency?
    • Has it been adequately tested with unit, integration, and end-to-end tests?
    • Are there any known defects or issues?
    • Is the code well-documented?
    • Are changes to documentation reflected in the code?

UI Checks:

  • UI Checks
    • If a UI design is provided/ does it follow it?
    • Does every button work?
    • Is the data displayed logical? Is it what you expected?
    • Does every validation work?
    • Does this interface feel intuitive?
    • What about slow network? Offline?
    • What if the gridproxy/graphql/chain is failing?
    • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code Quality Checks
    • Code formatted/linted? Are there unused imports? .. etc
    • Is there redundant/repeated code?
    • Are there conditionals that are always true or always false?
    • Can we write this more concisely?
    • Can we reuse this code? If yes, where?
    • Will the changes be easy to maintain and update in the future?
    • Can this code become too complex to understand for other devs?
    • Can this code cause future integration problems?

Testing Checklist

  • Does it Meet the specified acceptance criteria.
  • Test if changes can affect any other functionality.
  • Tested with unit, integration, and end-to-end tests.
  • Tested the un-happy path and rollback scenarios.
  • Documentation updated to meet the latest changes.
  • Check automated tests working successfully with the changes.
  • Can be covered by automated tests.

General Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add sshkey alert to casper labs too
Screenshot 2025-06-23 at 14 42 28
since it needs it
Screenshot 2025-06-23 at 14 43 40

@samaradel
Copy link
Contributor Author

@amiraabouhadid as per @AhmedHanafy725 any solution with a domain doesn't require sshkeys alert

@samaradel samaradel requested a review from amiraabouhadid June 23, 2025 12:13
@ramezsaeed
Copy link
Contributor

Test scenarios:

  • Test if the messages still exists for solution if the ssh key had been deleted.
  • Test the ssh messages disappear i case multiple ssh and key message still exists.
  • test after kyc process done all messages disappear.

@samaradel samaradel marked this pull request as draft June 24, 2025 05:48
@amiraabouhadid
Copy link
Contributor

alert shows when i delete ssh keys
Screenshot 2025-07-01 at 16 39 15
alert disappears after ssh key is generated
Screenshot 2025-07-01 at 16 40 21
correct alerts shown for newly created account with no kyc and no ssh
FULL VM:
Screenshot 2025-07-01 at 16 41 37
MICRO VM:
Screenshot 2025-07-01 at 16 42 42

CAPROVER:
Screenshot 2025-07-01 at 16 42 11
k8s:
Screenshot 2025-07-01 at 16 43 02
algorand:
Screenshot 2025-07-01 at 16 43 23
casperlabs:
Screenshot 2025-07-01 at 16 44 14
and in every other solution in labs

@amiraabouhadid
Copy link
Contributor

kyc alert disappears after kyc is verified correctly
Screenshot 2025-07-01 at 16 50 48
and so does the ssh alert

@amiraabouhadid
Copy link
Contributor

@AhmedHanafy725 just to confirm, kyc and ssh key alert should be on all solutions, correct?

@AhmedHanafy725
Copy link
Contributor

@AhmedHanafy725 just to confirm, kyc and ssh key alert should be on all solutions, correct?

yes

@samaradel samaradel merged commit aa8dead into development Jul 2, 2025
3 checks passed
@samaradel samaradel deleted the dev_kyc_alert branch July 2, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants