Relocate SYCL scan-by-segment to pstl/hetero/dpcpp
#2275
Merged
+172
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmichel11
changed the title
pstl/hetero/dpcpppstl/hetero/dpcpp
MikeDvorskiy
reviewed
Jun 3, 2025
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_scan_by_segment.h
Outdated
Show resolved
Hide resolved
|
Overall, looks good to me, excepting one minor comment. |
danhoeflinger
previously approved these changes
Jun 3, 2025
mmichel11
dismissed stale reviews from danhoeflinger and SergeyKopienko
via
ef54da7
mmichel11
dismissed stale reviews from MikeDvorskiy and SergeyKopienko
via
fc2ca42
|
I noticed some header includes in the moved scan-by-segment file are now unnecessary and a few others should be present. I updated these. |
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
mmichel11
force-pushed
the
dev/mmichel11/scan_by_segment_move_sycl_code
branch
from
fc2ca42 to
82d86e0
Compare
|
@mmichel11 thank you for this PR! |
timmiesmith
pushed a commit
that referenced
this pull request
Jun 9, 2025
* Moves SYCL specific code to `pstl/hetero/dpcpp` to align with our general design --------- Signed-off-by: Matthew Michel <matthew.michel@intel.com>
danhoeflinger
pushed a commit
that referenced
this pull request
Jun 13, 2025
* Moves SYCL specific code to `pstl/hetero/dpcpp` to align with our general design --------- Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2210.
The current SYCL implementation of the scan-by-segment algorithms is in the
internaldirectory in theoneapi::dpl::__par_backend_heteronamespace. This does not align with our general architecture, so the implementation has been moved topstl/hetero/dpcpp/parallel_backend_sycl_scan_by_segment.h. Furthermore,__pattern_scan_by_segmenthas been relocated topstl/hetero/algorithm_impl_hetero.h.Additionally, the following small tweaks are made:
::std->std__pattern_scan_by_segment