Skip to content

Commit 13a2b34

Browse files
authored
[cmake] update MKLConfig to 2025.1 release and gtest cmake to 3.13 (#657)
1 parent 8517a20 commit 13a2b34

File tree

5 files changed

+23
-20
lines changed

5 files changed

+23
-20
lines changed

.github/workflows/pr.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,13 @@ jobs:
8181
- name: Install compiler
8282
if: steps.domain_check.outputs.result == 'true'
8383
run: |
84-
wget --progress=dot:giga https://registrationcenter-download.intel.com/akdlm/IRC_NAS/ac92f2bb-4818-4e53-a432-f8b34d502f23/intel-dpcpp-cpp-compiler-2025.0.0.740_offline.sh
85-
sudo bash intel-dpcpp-cpp-compiler-2025.0.0.740_offline.sh -s -a -s --action install --eula accept
84+
wget --progress=dot:giga https://registrationcenter-download.intel.com/akdlm/IRC_NAS/cd63be99-88b0-4981-bea1-2034fe17f5cf/intel-dpcpp-cpp-compiler-2025.1.0.573_offline.sh
85+
sudo bash intel-dpcpp-cpp-compiler-2025.1.0.573_offline.sh -s -a -s --action install --eula accept
8686
- name: Install Intel oneMKL
8787
if: steps.domain_check.outputs.result == 'true'
8888
run: |
89-
wget --progress=dot:giga https://registrationcenter-download.intel.com/akdlm/IRC_NAS/79153e0f-74d7-45af-b8c2-258941adf58a/intel-onemkl-2025.0.0.940_offline.sh
90-
sudo bash intel-onemkl-2025.0.0.940_offline.sh -s -a -s --action install --eula accept
89+
wget --progress=dot:giga https://registrationcenter-download.intel.com/akdlm/IRC_NAS/dc93af13-2b3f-40c3-a41b-2bc05a707a80/intel-onemkl-2025.1.0.803_offline.sh
90+
sudo bash intel-onemkl-2025.1.0.803_offline.sh -s -a -s --action install --eula accept
9191
- name: Configure/Build for a domain
9292
if: steps.domain_check.outputs.result == 'true'
9393
run: |

cmake/mkl/MKLConfig.cmake

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,8 @@ endif()
224224

225225
# Determine Compiler Family
226226
if(CXX_COMPILER_NAME STREQUAL "dpcpp" OR CXX_COMPILER_NAME STREQUAL "dpcpp.exe"
227-
OR CXX_COMPILER_NAME STREQUAL "icpx" OR CXX_COMPILER_NAME STREQUAL "icx.exe")
227+
OR CXX_COMPILER_NAME STREQUAL "icpx" OR CXX_COMPILER_NAME STREQUAL "icx.exe"
228+
OR CXX_COMPILER_NAME STREQUAL "mpiicpx" OR CXX_COMPILER_NAME STREQUAL "mpiicx.bat")
228229
set(SYCL_COMPILER ON)
229230
endif()
230231
if(C_COMPILER_NAME MATCHES "^clang" OR CXX_COMPILER_NAME MATCHES "^clang")
@@ -408,7 +409,7 @@ endif()
408409

409410
# Define MKL_THREADING
410411
# All APIs support sequential threading
411-
# SYCL API supports oneTBB and OpenMP threadings, but OpenMP threading might have composability problem on CPU device with other SYCL kernels
412+
# SYCL API supports oneTBB and OpenMP threadings
412413
if(SYCL_COMPILER)
413414
set(MKL_SYCL_THREADING_LIST "sequential" "intel_thread" "tbb_thread")
414415
set(DEFAULT_MKL_SYCL_THREADING tbb_thread)
@@ -420,12 +421,6 @@ if(SYCL_COMPILER)
420421
set(SYCL_COMPILER OFF)
421422
mkl_message(STATUS "MKL::MKL_SYCL target will not be available.")
422423
endif()
423-
if(MKL_SYCL_THREADING STREQUAL "intel_thread")
424-
mkl_message(STATUS "Using MKL::MKL_SYCL* targets with intel_thread may have potential composability problems on CPU device with other SYCL kernels.")
425-
add_custom_target(MKL_SYCL_MESSAGE
426-
COMMAND ${CMAKE_COMMAND} -E cmake_echo_color --red
427-
"Warning: Using MKL::MKL_SYCL* targets with intel_thread may have potential composability problems on CPU device with other SYCL kernels.")
428-
endif()
429424
endif()
430425
# C, Fortran API
431426
set(MKL_THREADING_LIST "sequential" "intel_thread" "tbb_thread")
@@ -509,12 +504,20 @@ if(SYCL_COMPILER)
509504
list(APPEND MKL_SYCL_COPT "-fsycl")
510505
list(APPEND MKL_SYCL_LOPT "-fsycl")
511506
if(MKL_SYCL_LINK STREQUAL "static")
512-
list(APPEND MKL_SYCL_LOPT "-fsycl-device-code-split=per_kernel")
507+
if(WIN32)
508+
list(APPEND MKL_SYCL_LOPT "-fsycl-device-code-split:per_kernel")
509+
else()
510+
list(APPEND MKL_SYCL_LOPT "-fsycl-device-code-split=per_kernel")
511+
endif()
513512
endif()
514513
endif()
515514
if(ENABLE_OMP_OFFLOAD)
516515
if(MKL_LINK STREQUAL "static")
517-
list(APPEND MKL_OFFLOAD_LOPT "-fsycl-device-code-split=per_kernel")
516+
if(WIN32)
517+
list(APPEND MKL_OFFLOAD_LOPT "-fsycl-device-code-split:per_kernel")
518+
else()
519+
list(APPEND MKL_OFFLOAD_LOPT "-fsycl-device-code-split=per_kernel")
520+
endif()
518521
endif()
519522
endif()
520523

@@ -998,7 +1001,6 @@ if(SYCL_COMPILER)
9981001
if(NOT TARGET MKL::MKL_SYCL)
9991002
add_library(MKL::MKL_SYCL INTERFACE IMPORTED GLOBAL)
10001003
add_library(MKL::MKL_DPCPP ALIAS MKL::MKL_SYCL)
1001-
add_dependencies(MKL::MKL_SYCL MKL_SYCL_MESSAGE)
10021004
endif()
10031005
target_compile_options(MKL::MKL_SYCL INTERFACE $<$<COMPILE_LANGUAGE:CXX>:${MKL_SYCL_COPT}>)
10041006
target_link_libraries(MKL::MKL_SYCL INTERFACE ${MKL_SYCL_LINK_LINE} ${MKL_SYCL_THREAD_LIB} ${MKL_SYCL_SUPP_LINK})
@@ -1011,7 +1013,6 @@ if(SYCL_COMPILER)
10111013
endif()
10121014
string(TOUPPER ${MKL_SYCL_DOMAIN} MKL_SYCL_DOMAIN)
10131015
add_library(MKL::MKL_SYCL::${MKL_SYCL_DOMAIN} INTERFACE IMPORTED GLOBAL)
1014-
add_dependencies(MKL::MKL_SYCL::${MKL_SYCL_DOMAIN} MKL_SYCL_MESSAGE)
10151016
target_compile_options(MKL::MKL_SYCL::${MKL_SYCL_DOMAIN} INTERFACE $<$<COMPILE_LANGUAGE:CXX>:${MKL_SYCL_COPT}>)
10161017
# Only dynamic link has domain specific libraries
10171018
# Domain specific targets still use mkl_sycl for static

cmake/mkl/MKLConfigVersion.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,16 @@
1717
# SPDX-License-Identifier: Apache-2.0
1818
#===============================================================================
1919

20-
set(PACKAGE_VERSION "2025.0.0")
20+
set(PACKAGE_VERSION "2025.1.0")
2121

2222
if(PACKAGE_VERSION VERSION_LESS PACKAGE_FIND_VERSION)
2323
set(PACKAGE_VERSION_COMPATIBLE FALSE)
2424
else()
2525

26-
if("2025.0.0" MATCHES "^([0-9]+)\\.")
26+
if("2025.1.0" MATCHES "^([0-9]+)\\.")
2727
set(CVF_VERSION_MAJOR "${CMAKE_MATCH_1}")
2828
else()
29-
set(CVF_VERSION_MAJOR "2025.0.0")
29+
set(CVF_VERSION_MAJOR "2025.1.0")
3030
endif()
3131

3232
if(PACKAGE_FIND_VERSION_MAJOR STREQUAL CVF_VERSION_MAJOR)

deps/googletest/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ else()
5050
cmake_policy(SET CMP0048 NEW)
5151
project(gtest VERSION 1.8.1 LANGUAGES CXX C)
5252
endif()
53-
cmake_minimum_required(VERSION 2.6.4)
53+
cmake_minimum_required(VERSION 3.13)
5454

5555
if (POLICY CMP0063) # Visibility
5656
cmake_policy(SET CMP0063 NEW)

deps/googletest/cmake/internal_utils.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,9 @@ function(cxx_executable name dir libs)
242242
endfunction()
243243

244244
# Sets PYTHONINTERP_FOUND and PYTHON_EXECUTABLE.
245+
if (CMAKE_VERSION VERSION_LESS 3.27)
245246
find_package(PythonInterp)
247+
endif()
246248

247249
# cxx_test_with_flags(name cxx_flags libs srcs...)
248250
#

0 commit comments

Comments
 (0)