Skip to content

[RNG] Add PCG64 DXSM #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iMartyan
Copy link
Contributor

@iMartyan iMartyan commented May 7, 2025

Description

The PCG is a family of random number generators based on linear congruential generator (LCG). The algorithm applies permutation function to improve statistical properties of LCG.
PCG64 DXSM uses double xorshift multiply output function and has a period of 2^128.

PR includes implementation and tests.

Spec PR: uxlfoundation/oneAPI-spec#621

Checklist

New features

  • Have you provided motivation for adding a new feature?
  • Have you added relevant tests?

@iMartyan iMartyan marked this pull request as ready for review May 7, 2025 16:32
@iMartyan iMartyan requested a review from a team as a code owner May 7, 2025 16:32
Copy link
Contributor

@andreyfe1 andreyfe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please, attach the log with tests passed

@iMartyan iMartyan added this to the v0.8 milestone May 21, 2025
@iMartyan iMartyan added the API A request to add/change/fix/improve the API label May 21, 2025
@iMartyan
Copy link
Contributor Author

log.txt

Log attached

Copy link
Contributor

@aelizaro aelizaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@iMartyan iMartyan merged commit ca1ecc2 into uxlfoundation:develop May 27, 2025
8 checks passed
@vmakovet vmakovet mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API A request to add/change/fix/improve the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants