Skip to content

Add rbf_kernel Function #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tanannie22
Copy link
Contributor

Description

Issue: #2313

Changes Made:

  • Updated sklearnex/metrics/pairwise.py to utilize oneDAL for rbf_kernel.
  • Added tests in sklearnex/metrics/tests/test_metrics.py to validate correctness.
  • Added a benchmark notebook (examples/notebooks/benchmark_rbf_kernel.ipynb) to compare performance between sklearn and sklearnex.

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

* chore(deps): update dependency jinja2 to v3.1.6 [security] (uxlfoundation#2345)

* feature: add RBF kernel implementation and integrate with dispatcher

* integrate RBF kernel in sklearnex/metrics

* add benchmark_rbf_kernel.ipynb

* revert Jinja2 version change

* remove unused RBF kernel mapping from dispatcher

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andrie Dazlee, Nurin Miza Afiqah <nurin.miza.afiqah.andrie.dazlee@intel.com>
Signed-off-by: Andrie Dazlee, Nurin Miza Afiqah <nurin.miza.afiqah.andrie.dazlee@intel.com>
Signed-off-by: Mohamad, Siti Nurhanisah <siti.nurhanisah.mohamad@intel.com>
Signed-off-by: Tan, An Nie <an.nie.tan@intel.com>
@tanannie22 tanannie22 changed the title Add rbf_kernel Function (#3) Add rbf_kernel Function Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sklearnex/metrics/pairwise.py 96.15% 1 Missing ⚠️
Flag Coverage Δ
azure 78.11% <92.30%> (+0.05%) ⬆️
github ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sklearnex/metrics/pairwise.py 96.55% <96.15%> (-3.45%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@syakov-intel
Copy link
Contributor

@tanannie22 would you like to continue working on it?

@tanannie22
Copy link
Contributor Author

@tanannie22 would you like to continue working on it?

Hi @syakov-intel, I'm still working on this, but I'm currently facing some challenges with enabling the function to compute on GPU. If you have any ideas on enabling the function to compute on GPU, it would really help me move faster. I’d appreciate any suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants