-
Notifications
You must be signed in to change notification settings - Fork 182
update: update algorithm.rst based on current implementation #2354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: update algorithm.rst based on current implementation #2354
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 43 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's also missing some details about specifics of support - for example, for TSNE, it only works with n_components=2
.
Also appears to be missing some algorithms like ExtraTrees. |
Added! thx |
Not related to the aim of this PR, but I'm thinking it'd be nice to have the classes listed here offer clickable links to the sklearn docs. Since we have intersphinx with sklearn confgured on it, it could be done with something like this:
or
|
@yuejiaointel Please merge the main branch here which has the numpydoc check. Some headers like 'Data formats' are not part of numpydoc format. |
|
LGTM, but please address the formatting errors catched by the doc CI. |
This PR updates the sklearnex doc with new features implemented. Specifically, it gets updated based on each algorithm file _onedal_supported function.
PR completeness and readability
Testing