[enhancement] set specific failure for host builds with "target_offload" #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
/intelci: run |
|
/intelci: run |
icfaust
requested review from
yuejiaointel,
david-cortes-intel and
Vika-F
as code owners
|
/intelci: run |
|
/intelci: run |
david-cortes-intel
pushed a commit
to david-cortes-intel/scikit-learn-intelex
that referenced
this pull request
Jun 18, 2025
…ad" (uxlfoundation#2388) * Update sycl.cpp * Update _sycl_queue_manager.py * Update test_config.py * Update sycl.cpp * Update sycl.cpp * Update sycl.cpp * Update sycl.cpp * Update dal.cpp * Update dal.cpp * fix logic * formatting * convert into an object * Update test_config.py * Update test_config.py * Update test_config.py * Update test_config.py * Update test_config.py * Update sycl.cpp * Update test_config.py * Update _device_offload.py * Update _sycl_queue_manager.py * Update test_config.py * Update ci.yml * Update ci.yml * Update sycl.cpp * Update sycl.cpp * Update test_config.py * Update sycl.cpp * Update _sycl_queue_manager.py * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update build-and-test-lnx.yml * Update sycl.cpp * Update test_config.py * Update test_config.py * Update test_config.py * Update sycl.cpp * Update _config.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows for a standardized interface to all the backends with respect to "SyclQueue" by adding a function to the pybind11 interface. This simplifies the logic for dpc++ builds, and reduces wasted cycles. This acts as the standardized failure point for when someone attempts to use the target_offload sklearnex config with a host build when the value is not "auto".
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance