-
Notifications
You must be signed in to change notification settings - Fork 182
Fixes for sklearn 1.7 pre-release support #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for sklearn 1.7 pre-release support #2451
Conversation
/azp run Nightly |
Azure Pipelines successfully started running 1 pipeline(s). |
/intelci: run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 41 files with indirect coverage changes 🚀 New features to boost your workflow:
|
/azp run Nightly |
Azure Pipelines successfully started running 1 pipeline(s). |
"numpy", | ||
"array_api_compat.numpy", | ||
"numpy.array_api", | ||
"sklearn.externals.array_api_compat.numpy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does one end up with this namespace for an array object? Could it somehow happen that it'd end up with a different name like <package that imports sklearn>.sklearn.externals.array_api_compat.numpy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are getting at the core issue here, which is that this function is fragile. We should think about how to make it more robust.
Please merge main into the PR and rerun CI for me to review @Alexsandruss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please share the forest fix ticket to me before merging this PR.
@mergify backport rls/2025.6.0-rls |
✅ Backports have been created
|
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- Co-authored-by: icfaust <icfaust@gmail.com> (cherry picked from commit 95c73bd)
@mergify backport rls/2025.5.0-rls |
✅ Backports have been created
|
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- Co-authored-by: icfaust <icfaust@gmail.com> (cherry picked from commit 95c73bd)
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- (cherry picked from commit 95c73bd) Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> Co-authored-by: icfaust <icfaust@gmail.com>
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- Co-authored-by: icfaust <icfaust@gmail.com>
Description
Fixes for sklearn 1.7 pre-release support:
sklearn.utils._joblib
module in pairwise distancesmax_iter
for sklearn>=1.7onedal.utils._array_api._is_numpy_namespace
to support new sklearn's xp nameNote: this PR fixes critical failures, there are still sklearnex and sklearn test failures.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
N/A.