Fixes for sklearn 1.7 pre-release support #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Nightly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/intelci: run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 41 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
/azp run Nightly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "numpy", | ||
| "array_api_compat.numpy", | ||
| "numpy.array_api", | ||
| "sklearn.externals.array_api_compat.numpy", |
There was a problem hiding this comment.
How does one end up with this namespace for an array object? Could it somehow happen that it'd end up with a different name like <package that imports sklearn>.sklearn.externals.array_api_compat.numpy ?
There was a problem hiding this comment.
I think you are getting at the core issue here, which is that this function is fragile. We should think about how to make it more robust.
|
Please merge main into the PR and rerun CI for me to review @Alexsandruss |
13 tasks
icfaust
approved these changes
Jun 9, 2025
|
@mergify backport rls/2025.6.0-rls |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- Co-authored-by: icfaust <icfaust@gmail.com> (cherry picked from commit 95c73bd)
9 tasks
|
@mergify backport rls/2025.5.0-rls |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- Co-authored-by: icfaust <icfaust@gmail.com> (cherry picked from commit 95c73bd)
9 tasks
napetrov
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- (cherry picked from commit 95c73bd) Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> Co-authored-by: icfaust <icfaust@gmail.com>
david-cortes-intel
pushed a commit
to david-cortes-intel/scikit-learn-intelex
that referenced
this pull request
Jun 11, 2025
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- Co-authored-by: icfaust <icfaust@gmail.com>
7 tasks
napetrov
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Fixes for sklearn 1.7 pre-release support * Fix ensemble probabilities interval * Change scaling method to `clip` --------- (cherry picked from commit 95c73bd) Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> Co-authored-by: icfaust <icfaust@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for sklearn 1.7 pre-release support:
sklearn.utils._joblibmodule in pairwise distancesmax_iterfor sklearn>=1.7onedal.utils._array_api._is_numpy_namespaceto support new sklearn's xp nameNote: this PR fixes critical failures, there are still sklearnex and sklearn test failures.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
N/A.