-
Notifications
You must be signed in to change notification settings - Fork 182
fix: Use last known good oneDAL Windows Nightly for CI #2463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use last known good oneDAL Windows Nightly for CI #2463
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This is neither a fix, or nor a nightly now. It breaks the utility of the CI in providing the latest changes for testing in sklearnex publicly. I believe reverting the known oneDAL PR is the better course of action. i would think this would be the proper solution if we had evidence of which symbol is missing. did the dependency walker yield anything @ahuber21 ? |
Dependency Walker didn't help. Still convinced that it's a tooling issue. If our tools prevent us from pushing updates, I think we need to fix or disable them. It is just a temporary fix, but IMO reverting 3155 is not an option. |
Gotcha. Then the solution should be disabling the windows side of the workflow entirely with a single line if statement. As the person who developed this CI, I dont see a compelling reason to keep the windows workflow running given that it now just duplicates the azp windows jobs on sklearn versions we generally dont officially support. it will waste of our finite github resources, but I am willing to listen to technical arguments that you otherwise may have @ahuber21 @ethanglaser @napetrov |
Should this be closed at this point? |
While investigating the Windows CI fails, likely introduced by uxlfoundation/oneDAL#3155, use a last known good commit hash for checks in this repository.