Skip to content

fix: Use last known good oneDAL Windows Nightly for CI #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e471922
generate artifacts
ahuber21 May 5, 2025
e220656
fix upload-artifact version
ahuber21 May 5, 2025
6f24a2c
remove failing test
ahuber21 May 5, 2025
0a19bdf
tracebacK
ahuber21 May 6, 2025
498ecb2
further tests
ahuber21 May 6, 2025
2600ca3
catch all exceptions
ahuber21 May 6, 2025
c6e2515
change path
ahuber21 May 6, 2025
3227c5f
use last known good run id
ahuber21 May 8, 2025
e1b5c92
remove additional tests
ahuber21 May 8, 2025
37b3613
restore init
ahuber21 May 8, 2025
0c730eb
upload LKG artifacts
ahuber21 May 9, 2025
b681911
fix upload
ahuber21 May 9, 2025
e3ea811
rename artifact
ahuber21 May 9, 2025
de7238e
upload all site-packages
ahuber21 May 9, 2025
3eb88a0
upload venv
ahuber21 May 9, 2025
af739e6
re-introduce latest nightly
ahuber21 May 9, 2025
c4591bb
some more prints
ahuber21 May 9, 2025
fdadc8a
list dir contents
ahuber21 May 9, 2025
c020ea3
use test nightly build with moved header
ahuber21 May 12, 2025
8aebb9f
Use 3155 revert SHA
ahuber21 May 12, 2025
577f9ec
new build test
Alexandr-Solovev May 15, 2025
f2cda8d
Merge remote-tracking branch 'origin/main' into dev/ahuber/debug-nigh…
ahuber21 May 16, 2025
6c614cc
try2
Alexandr-Solovev May 19, 2025
2049112
more debug info
Alexandr-Solovev May 19, 2025
1456ef9
fix version
Alexandr-Solovev May 19, 2025
de21e72
Update daal4py/__init__.py
ethanglaser May 19, 2025
dd5811c
Update daal4py/__init__.py
ethanglaser May 19, 2025
968cfc6
Update daal4py/__init__.py
ethanglaser May 19, 2025
5d79054
Update daal4py/__init__.py
ethanglaser May 19, 2025
430990a
Update daal4py/__init__.py
ethanglaser May 19, 2025
0a9fb81
minor fix
Alexandr-Solovev May 20, 2025
8a872ad
minor revert
Alexandr-Solovev May 20, 2025
08bb94f
minor fix
Alexandr-Solovev May 20, 2025
dce923e
minor fix
Alexandr-Solovev May 21, 2025
7e0f249
fix for version
Alexandr-Solovev May 21, 2025
3402c1c
remove comments to fix lint
ethanglaser May 22, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@
name: CI
on:
pull_request:
branches: [ "main" ]
branches: ["main"]
push:
branches:
- main
@@ -56,7 +56,7 @@ jobs:
- name: Install Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.PYTHON_VERSION }}
python-version: ${{ matrix.PYTHON_VERSION }}
- name: Get run ID of "Nightly-build" workflow
id: get-run-id
run: |
@@ -187,9 +187,11 @@ jobs:
shell: bash
run: |
OTHER_REPO="uxlfoundation/oneDAL"
TEST_SHA=7b80aea04d7c19d7b431117f4421a1f5ea113a3e
echo "Getting run for hardcoded commit hash ${TEST_SHA}"
WF_NAME="Nightly-build"
JQ_QUERY='map(select(.event == "workflow_dispatch" or .event == "schedule")) | .[0].databaseId'
RUN_ID=`gh run --repo ${OTHER_REPO} list --workflow "${WF_NAME}" --json databaseId,event --status success --jq "${JQ_QUERY}"`
JQ_QUERY="map(select(.event == \"workflow_dispatch\" or .event == \"schedule\" and .headSha == \"${TEST_SHA}\")) | .[0].databaseId"
RUN_ID=$(gh run --repo ${OTHER_REPO} list --workflow "${WF_NAME}" --json databaseId,event,headSha --status success --jq "${JQ_QUERY}")
echo "Detected latest run id of ${RUN_ID} for workflow ${WF_NAME}"
echo "run-id=${RUN_ID}" >> "$GITHUB_OUTPUT"
env:
@@ -251,7 +253,7 @@ jobs:
pip install cpufeature clang-format pyyaml
pip install -r dependencies-dev
for /f "delims=" %%c in ('python -m pip freeze ^| grep numpy') do echo NUMPY_BUILD=%%c>> %GITHUB_ENV%
- name: System info
- name: System info
shell: cmd
run: |
call .\venv\Scripts\activate.bat
@@ -265,6 +267,11 @@ jobs:
set PREFIX=.
set PYTHON=python
call .\conda-recipe\bld.bat
- name: Upload venv
uses: actions/upload-artifact@v4
with:
name: venv-${{ matrix.PYTHON_VERSION }}-${{ matrix.SKLEARN_VERSION }}
path: ${{ github.workspace }}\venv
- name: Install testing requirements
shell: cmd
run: |
@@ -304,7 +311,7 @@ jobs:
with:
name: coverage_win_Py${{ matrix.PYTHON_VERSION }}_${{ matrix.SKLEARN_VERSION }}
path: |
*_win${{ matrix.PYTHON_VERSION }}_${{ matrix.SKLEARN_VERSION }}.info
*_win${{ matrix.PYTHON_VERSION }}_${{ matrix.SKLEARN_VERSION }}.info
- name: Sklearn testing [preview]
shell: cmd
run: |
31 changes: 27 additions & 4 deletions daal4py/sklearn/monkeypatch/tests/test_patching.py
Original file line number Diff line number Diff line change
@@ -37,17 +37,33 @@ def get_branch(s):


def run_parse(mas, result):
name, dtype = mas[0].split()
print("\n[run_parse] mas:")
for idx, val in enumerate(mas):
print(f" mas[{idx}] = {val!r}")

try:
name, dtype = mas[0].split()
print(f"[run_parse] Parsed name = {name}, dtype = {dtype}")
except ValueError as e:
print(f"[run_parse] ERROR while splitting mas[0]: {mas[0]!r}")
print(f"[run_parse] .split() gives: {mas[0].split()}")
raise

temp = []
INFO_POS = 6
for i in range(1, len(mas)):
mas[i] = mas[i][INFO_POS:] # remove 'INFO: '
print(f"[run_parse] Processing mas[{i}]: {mas[i]!r}")
mas[i] = mas[i][INFO_POS:]
print(f"[run_parse] After trimming INFO: {mas[i]!r}")
if not mas[i].startswith("sklearn"):
ind = name + " " + dtype + " " + mas[i]
result[ind] = get_branch(temp)
branch = get_branch(temp)
print(f"[run_parse] Adding result: {ind!r} => {branch}")
result[ind] = branch
temp.clear()
else:
temp.append(mas[i])
print(f"[run_parse] Appended to temp: {temp!r}")


def get_result_log():
@@ -61,13 +77,20 @@ def get_result_log():
]
)
except subprocess.CalledProcessError as e:
print("[get_result_log] Subprocess failed:")
print(e)
exit(1)

mas = []
result = {}
for i in process.decode().split("\n"):
decoded = process.decode().split("\n")
print("[get_result_log] Process output:")
for line in decoded:
print(f" {line!r}")

for i in decoded:
if not i.startswith("INFO") and len(mas) != 0:
print(f"[get_result_log] Switching block at line: {i!r}")
run_parse(mas, result)
mas.clear()
mas.append(i.strip())
Loading
Oops, something went wrong.