-
Notifications
You must be signed in to change notification settings - Fork 182
MAINT: Deploy 2025.5 docs #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
https://yuejiaointel.github.io/scikit-learn-intelex |
@yuejiaointel Question here: why does it need to have a folder |
@yuejiaointel It looks like the docs in your fork were already overwritten, but I am wondering now: it looks like the change in the location of scikit-learn-intelex/doc/sources/conf.py Line 169 in 18bfe50
Would the version switcher still work for the older versions (meaning: shows all the available versions, including 2025.5) i the versions.json file gets moved to under |
Gave it a try on my fork and it looks like the version switcher doesn't work for previous versions: So looks like we'll have to revert the location in |
@yuejiaointel I've updated this PR with a modified version of the docs that removes |
Hi David, |
yes it would still work, as versions.json is used only for version switcher |
Hi David, |
I don't think it'd be a problem to have the version switcher not work on the local builds, because usually only one version is built. But otherwise, perhaps it could be controlled through an environment variable, so that running the script with |
It actually didn't work - for example, if you roll back to this commit:
and hard-push that to the branch from your github pages, the version switcher will show when browsing 'latest' and '2025.5', but it disappears after switching to other versions. |
Here I've redeployed from the rolled back commit: |
That make sense, I think current change is good, thx for all the experiments! |
You are right, that is a good catch, I can reproduce on my end as well. I think the reason is previous versions already having a get request to /scikit-learn-intelex/versions.json in the htmls hardcoded, so moving them to docs will make them unable to get the verisons.json. But latest works because we have changed the conf already so htmls are sending correct request to get verisons.json. I'll make changes in pipelkine as well to also keep versions.json outside |
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s): #6 (for example)
Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing